Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock dependencies #216

Merged
merged 26 commits into from
May 22, 2024
Merged

Lock dependencies #216

merged 26 commits into from
May 22, 2024

Conversation

liamhuber
Copy link
Member

To create a stable environment for MyBinder now that this project is not being actively developed.

liamhuber added 9 commits May 17, 2024 10:58
And let's see what happens
In the newer pyiron_atomistics dependency this should now be resolved
Locally this created an environment amenable to all demo notebooks. Let's check it on MyBinder.
And let's see what happens
In the newer pyiron_atomistics dependency this should now be resolved
Locally this created an environment amenable to all demo notebooks. Let's check it on MyBinder.
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/ironflow/lock_dependencies

@liamhuber
Copy link
Member Author

Ok, it works fine on conda here, but the pip check fails:

 Installing collected packages: ironflow
Successfully installed ironflow-0.post0.dev1
Run pip check
ironflow 0.post0.dev1 requires openjdk, which is not installed.
ironflow 0.post0.dev1 requires pyiron-data, which is not installed.
ironflow 0.post0.dev1 has requirement pyiron-gui==0.0.8, but you have pyiron-gui 0.post0.dev38.
pymatgen 2024.5.1 has requirement numpy>=1.25.0, but you have numpy 1.23.5.
pyiron-atomistics 0.3.3 has requirement numpy>=1.24.3, but you have numpy 1.23.5.

The openjdk and pyiron-data complaints are perfectly reasonable, these are conda-only packages.

I'm very confused about the pyiron-gui statement, as both conda and setup.py specifically ask for 0.0.8.

The pymatgen and pyiron-atomistics problems are probably linked. pyiron-atomistics just asks for ">=" requirements, and while the older version of numpy is fine for conda, it is not OK for pip. Looking at the repo, the most recent version I see that allows numpy <1.24.0 is 0.2.61.

@liamhuber
Copy link
Member Author

Ok, there just flat-out is no combination of versions that will pass a pip check demanding numpy <1.24. However, I thought I needed this for np.float, which is gone as of 1.24, but actually the code uses np.floating so maybe I'm just misremembering -- and that's available starting in 1.24 until now.

@liamhuber
Copy link
Member Author

Run pip check
ironflow 0.post0.dev1 has requirement pyiron-gui==0.0.8, but you have pyiron-gui 0.post0.dev38.

I wonder if there isn't some bug in the versioning for this right in the pypi release? The conda version is showing as 0.0.8, as desired.

The windows tests just timed out; I'm not super stressed about it, but I'll bump the timeout limit a little

@liamhuber
Copy link
Member Author

Yeah, just getting the environment installed on windows was taking 12 minutes (of the 10 originally available), tests took seconds after.

Pip is happy with the relaxed bound too.

Calculations and recommendation system are all working well on MyBinder too.

Looks like this is good to go!

@liamhuber liamhuber merged commit f7c6779 into version_ci May 22, 2024
14 checks passed
@liamhuber liamhuber deleted the lock_dependencies branch May 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants