-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock dependencies #216
Lock dependencies #216
Conversation
And let's see what happens
In the newer pyiron_atomistics dependency this should now be resolved
Locally this created an environment amenable to all demo notebooks. Let's check it on MyBinder.
And let's see what happens
In the newer pyiron_atomistics dependency this should now be resolved
Locally this created an environment amenable to all demo notebooks. Let's check it on MyBinder.
This was simply a transcription error
Ok, it works fine on conda here, but the pip check fails:
The openjdk and pyiron-data complaints are perfectly reasonable, these are conda-only packages. I'm very confused about the pyiron-gui statement, as both conda and setup.py specifically ask for 0.0.8. The pymatgen and pyiron-atomistics problems are probably linked. pyiron-atomistics just asks for ">=" requirements, and while the older version of numpy is fine for conda, it is not OK for pip. Looking at the repo, the most recent version I see that allows numpy <1.24.0 is 0.2.61. |
Ok, there just flat-out is no combination of versions that will pass a pip check demanding numpy <1.24. However, I thought I needed this for |
I wonder if there isn't some bug in the versioning for this right in the pypi release? The conda version is showing as 0.0.8, as desired. The windows tests just timed out; I'm not super stressed about it, but I'll bump the timeout limit a little |
Yeah, just getting the environment installed on windows was taking 12 minutes (of the 10 originally available), tests took seconds after. Pip is happy with the relaxed bound too. Calculations and recommendation system are all working well on MyBinder too. Looks like this is good to go! |
To create a stable environment for MyBinder now that this project is not being actively developed.