Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding example #200

Merged
merged 5 commits into from
May 16, 2023
Merged

Add binding example #200

merged 5 commits into from
May 16, 2023

Conversation

liamhuber
Copy link
Member

  • Adds node for switching species
  • Update output dtyping dynamically on the array slicer/indexer
  • Debug "source code" representation for nodes defined in-notebook
  • Add an example for calculating solute-GB binding

liamhuber added 4 commits May 16, 2023 09:51
It was throwing an error in my new example. This is fine since this feature of the representations is just there for the user's convenience anyhow, and they obviously have easy access to source code for nodes defined this way!
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/ironflow/solutes

@liamhuber liamhuber added the format_black Invoke black formatting CI label May 16, 2023
@coveralls
Copy link

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 4996421564

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 23 (47.83%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 50.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ironflow/nodes/pyiron_atomistics.py 4 7 57.14%
ironflow/model/node.py 0 4 0.0%
ironflow/nodes/array.py 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
ironflow/model/node.py 1 68.84%
ironflow/nodes/array.py 4 71.67%
Totals Coverage Status
Change from base Build 4993897103: 0.09%
Covered Lines: 1873
Relevant Lines: 3685

💛 - Coveralls

@liamhuber liamhuber merged commit bcf71a6 into main May 16, 2023
@liamhuber liamhuber deleted the solutes branch May 16, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Invoke black formatting CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants