Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split node packages #199

Merged
merged 16 commits into from
May 16, 2023
Merged

Split node packages #199

merged 16 commits into from
May 16, 2023

Conversation

liamhuber
Copy link
Member

  • Deprecate (and hide) the older nodes
  • Split those that remain into multiple modules
  • Make pyiron_atomistics the default module on GUI instantiation

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/ironflow/split_node_packages

@liamhuber liamhuber added the format_black Invoke black formatting CI label May 15, 2023
@liamhuber liamhuber removed the format_black Invoke black formatting CI label May 15, 2023
@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 4986287753

  • 102 of 228 (44.74%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-10.6%) to 50.736%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ironflow/nodes/array.py 37 51 72.55%
ironflow/nodes/standard.py 23 43 53.49%
ironflow/nodes/plot.py 35 79 44.3%
ironflow/nodes/deprecated/flow_control.py 0 48 0.0%
Files with Coverage Reduction New Missed Lines %
ironflow/gui/workflows/canvas_widgets/flow.py 1 64.8%
ironflow/model/node.py 1 68.5%
Totals Coverage Status
Change from base Build 4985441295: -10.6%
Covered Lines: 1860
Relevant Lines: 3666

💛 - Coveralls

@liamhuber liamhuber merged commit 2ae8a53 into main May 16, 2023
@liamhuber liamhuber deleted the split_node_packages branch May 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants