-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty cache #491
Closed
+116
−8
Closed
Empty cache #491
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d540f15
Update validate_number_of_cores()
jan-janssen c859e07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 28e214a
fixes
jan-janssen a345de5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5d46715
fix test
jan-janssen 2fe6635
Merge remote-tracking branch 'origin/main' into validate_number_of_cores
jan-janssen 24f0571
Merge remote-tracking branch 'origin/main' into validate_number_of_cores
jan-janssen 9efd8a5
If the cache is empty execute the task again
jan-janssen 81183ed
Fix for the situation when the same task is executed twice (parallel …
jan-janssen cdba297
Add tests
jan-janssen e34b5de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a6079bf
one more fix
jan-janssen 7f151cc
clean up
jan-janssen 0f614d5
Add missing test
jan-janssen 382f86e
Update test_local_executor.py
jan-janssen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling for cache operations and implement atomic file operations.
The cache validation logic needs improvement in several areas:
dump
,get_output
) should have proper error handlingConsider implementing these improvements:
📝 Committable suggestion