Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add additional arguments to SLURM submission scripts #282

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

jan-janssen
Copy link
Member

@mgt16-LANL I added a first draft to support additional SLURM command line arguments, does this address your request in #281 ?

@jan-janssen jan-janssen changed the title Add option to add aditional arguments to SLURM submission scripts Add option to add additional arguments to SLURM submission scripts Feb 29, 2024
@jan-janssen jan-janssen linked an issue Feb 29, 2024 that may be closed by this pull request
@jan-janssen jan-janssen linked an issue Feb 29, 2024 that may be closed by this pull request
@mgt16-LANL
Copy link

Yes @jan-janssen - Thanks! I had pretty much hard-coded a similar workaround on my-end, but this should be useful for others as well.

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Feb 29, 2024
@jan-janssen
Copy link
Member Author

Yes @jan-janssen - Thanks! I had pretty much hard-coded a similar workaround on my-end, but this should be useful for others as well.

Great, I am going to add some tests and then merge these changes. I just might be a bit slow over the upcoming weeks as the conferences are coming up.

@jan-janssen jan-janssen merged commit f3956d6 into main Feb 29, 2024
24 checks passed
@jan-janssen jan-janssen deleted the slurm_arguments branch February 29, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more Slurm Options
3 participants