Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-janssen committed Nov 19, 2024
1 parent 78246d5 commit 3d66d31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 2 additions & 0 deletions executorlib/interactive/shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,8 @@ def _submit_function_to_separate_process(
active_task_dict[task_dict["future"]] = slots_required
task_kwargs = executor_kwargs.copy()
task_kwargs.update(resource_dict)
if "threads_per_core" in task_kwargs:
del task_kwargs["threads_per_core"]
task_kwargs.update(
{
"future_queue": qtask,
Expand Down
6 changes: 0 additions & 6 deletions tests/test_executor_backend_mpi.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ def test_meta_executor_parallel(self):
self.assertTrue(fs_1.done())

def test_errors(self):
with self.assertRaises(TypeError):
Executor(
max_cores=1,
resource_dict={"cores": 1, "threads_per_core": 2},
backend="local",
)
with self.assertRaises(TypeError):
Executor(
max_cores=1,
Expand Down

0 comments on commit 3d66d31

Please sign in to comment.