Skip to content

Commit

Permalink
Python compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-janssen committed Jan 20, 2024
1 parent e0c1ba4 commit e129187
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 9 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/unittests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ jobs:
- operating-system: ubuntu-latest
python-version: 3.9

- operating-system: ubuntu-latest
python-version: 3.8

steps:
- uses: actions/checkout@v2
- uses: conda-incubator/[email protected]
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ process.communicate()

## Remarks
* The `shell` parameter and the `env` parameter are not supported in `Popen()` and all derived methods.
* The `pipesize` parameter and the `process_group` parameter were removed for compatibility with python 3.9.
4 changes: 0 additions & 4 deletions conda_subprocess/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ def Popen(
errors=None,
text=None,
umask=-1,
pipesize=-1,
process_group=None,
):
# create run script
script, command = wrap_subprocess_call(
Expand Down Expand Up @@ -79,8 +77,6 @@ def Popen(
errors=errors,
text=text,
umask=umask,
pipesize=pipesize,
process_group=process_group,
)


Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ authors = [
readme = "README.md"
license = { file = "LICENSE" }
keywords = ["conda", "subprocess"]
requires-python = ">=3.8"
requires-python = ">=3.9"
classifiers = [
"Development Status :: 5 - Production/Stable",
"Topic :: Utilities",
"License :: OSI Approved :: BSD License",
"Intended Audience :: Science/Research",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down

0 comments on commit e129187

Please sign in to comment.