-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for potential installation #320
Conversation
WalkthroughThe recent changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- atomistics/calculators/lammps/potential.py (3 hunks)
Additional comments not posted (3)
atomistics/calculators/lammps/potential.py (3)
8-34
: LGTM! The installation guide is clear and well-structured.The
potential_installation
guide provides clear and detailed instructions for installingiprpy-data
and setting the resource path.
155-157
: LGTM! Including the installation guide in the error message is helpful.The updated error message in
_get_potential_df
now provides immediate assistance to users encountering issues with locating potential files.
343-343
: LGTM! Including the installation guide in the error message is helpful.The updated error message in
get_resource_path_from_conda
now provides immediate assistance to users encountering issues with finding the resource path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Based on this discussion I appended text to the error message. I guess @jan-janssen can update it to make it more accurate.
Summary by CodeRabbit
New Features
Bug Fixes
Usability Improvements