Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump spglib from 2.3.1 to 2.4.0 #265

Merged
merged 2 commits into from
May 23, 2024
Merged

Bump spglib from 2.3.1 to 2.4.0 #265

merged 2 commits into from
May 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2024

Bumps spglib from 2.3.1 to 2.4.0.

Release notes

Sourced from spglib's releases.

Spglib v2.4.0

What's Changed

🎉 New Features

🐞 Bug fixes

Other changes

Full Changelog: spglib/spglib@v2.3.1...v2.4.0

Changelog

Sourced from spglib's changelog.

v2.4.0 (11 Apr. 2024)

Main Changes

  • Separated the CMake sub-projects to be buildable as standalone projects with pre-installed Spglib C library: test, python, fortran
  • Bumped minimum CMake version to 3.20 (Note: previously the project was not tested for the minimum CMake version)
  • Migrated the example and package test to the ctest test-suite
  • Properly mark all deprecated functions where possible
  • Fix excessive debug/warning message prints
  • Debug and warning messages are controlled by:
    • Environment variable SPGLIB_DEBUG: Define any value to enable printing of debug messages
    • Environment variable SPGLIB_WARNING: Set to OFF to disable warning printing
    • CMake option SPGLIB_DEBUG, SPGLIB_WARNINGS: Disable the compilation of these messages all-together
  • Expanded Python distribution to more MacOS variants, including MacOS-14 (M1)

C Interface

  • Mark deprecated api with [[deprecated]] and pre-C23 equivalents
  • Explicitly mark public API for export

Python API

  • Fixed the Python module build and installation in the pure CMake environment (without scikit-build-core)
  • Use importlib to search and load the bundled spglib C library
  • Support editable installs
  • [#420] Raise TypeError when a given cell is invalid
  • [#420] Add type annotation for cell

CI

  • [#425] - Update to codecov v4
  • [#402] - Bump artifact actions to v4
  • [#402] - Build and inspect python sdist
  • [#431] - Test CMake versions
  • [#459] - Fix various CI issues
  • [#459] - Building for MacOS 14 (M1)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump spglib from 2.3.1 to 2.4.0
b40fab4 
Bumps [spglib](https://github.com/spglib/spglib) from 2.3.1 to 2.4.0.
- [Release notes](https://github.com/spglib/spglib/releases)
- [Changelog](https://github.com/spglib/spglib/blob/develop/ChangeLog.md)
- [Commits](spglib/spglib@v2.3.1...v2.4.0)

---
updated-dependencies:
- dependency-name: spglib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from jan-janssen as a code owner May 13, 2024 22:01
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 13, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 13, 2024 •
edited
Loading

Important

Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jan-janssen jan-janssen marked this pull request as draft May 13, 2024 22:24
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@jan-janssen jan-janssen reopened this May 23, 2024
@jan-janssen jan-janssen marked this pull request as ready for review May 23, 2024 16:26
@jan-janssen jan-janssen merged commit 7a20830 into main May 23, 2024
27 of 43 checks passed
@jan-janssen jan-janssen deleted the dependabot/pip/spglib-2.4.0 branch May 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen Awaiting requested review from jan-janssen jan-janssen is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jan-janssen