Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matgl #263

Merged
merged 8 commits into from
May 22, 2024
Merged

Update Matgl #263

merged 8 commits into from
May 22, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented May 6, 2024

Summary by CodeRabbit

  • Chores
    • Updated the matgl dependency from version 0.9.2 to 1.1.1 for improved performance and stability.

@jan-janssen
Copy link
Member Author

DGL backend not selected or invalid.  Assuming PyTorch for now.
E
======================================================================
ERROR: test_calc_evcurve (tests.test_ase_interface.test_evcurve_ase_matgl.TestEvCurve.test_calc_evcurve)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/matgl/utils/io.py", line 212, in load_model
    return cls_.load(fpaths, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/matgl/utils/io.py", line 129, in load
    model = cls(**d)
            ^^^^^^^^
TypeError: Potential.__init__() got an unexpected keyword argument 'calc_magmom'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/runner/work/atomistics/atomistics/tests/test_ase_interface/test_evcurve_ase_matgl.py", line 25, in test_calc_evcurve
    ase_calculator = M3GNetCalculator(matgl.load_model("M3GNet-MP-2021.2.8-PES"))
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/matgl/utils/io.py", line 214, in load_model
    raise ValueError(
ValueError: Bad serialized model or bad model name. It is possible that you have an older model cached. Please clear your cache by running `python -c "import matgl; matgl.clear_cache()"`

----------------------------------------------------------------------

@jan-janssen
Copy link
Member Author

The models online changed, that is why the MatGL tests fail. materialsvirtuallab/matgl#242 I guess we just have to wait for them to release a new version.

@jan-janssen jan-janssen marked this pull request as draft May 6, 2024 15:54
Copy link

coderabbitai bot commented May 22, 2024

Walkthrough

The recent update focuses on upgrading the matgl dependency from version 0.9.2 to 1.1.1 within the .ci_support/environment-matgl.yml file. This change ensures compatibility with the latest features and improvements in the matgl package.

Changes

File Change Summary
.ci_support/environment-matgl.yml Upgraded matgl version from 0.9.2 to 1.1.1

🐰✨
In the land of code so bright,
Matgl's version took a flight,
From nine-two to one-one-one,
New features and fixes, oh what fun!
Our CI's now up to date,
With dependencies first-rate!
🐇💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jan-janssen jan-janssen marked this pull request as ready for review May 22, 2024 21:12
@jan-janssen jan-janssen merged commit 79c11bf into main May 22, 2024
22 checks passed
@jan-janssen jan-janssen deleted the matgl branch May 22, 2024 21:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2ff7350 and a995393.
Files selected for processing (1)
  • .ci_support/environment-matgl.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .ci_support/environment-matgl.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant