Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more type hints #222

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Add some more type hints #222

merged 6 commits into from
Mar 15, 2024

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen requested a review from liamhuber March 14, 2024 18:45
@jan-janssen jan-janssen added the format_black Launch the pyiron/actions black formatting routine label Mar 14, 2024
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just some suggestions for more specificity.

atomistics/calculators/lammps/potential.py Outdated Show resolved Hide resolved
atomistics/calculators/lammps/potential.py Outdated Show resolved Hide resolved
atomistics/calculators/hessian.py Outdated Show resolved Hide resolved
@jan-janssen jan-janssen added format_black Launch the pyiron/actions black formatting routine and removed format_black Launch the pyiron/actions black formatting routine labels Mar 14, 2024
@jan-janssen jan-janssen merged commit fb4845a into main Mar 15, 2024
19 of 20 checks passed
@jan-janssen jan-janssen deleted the some_typing branch March 15, 2024 01:23
@jan-janssen jan-janssen mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Launch the pyiron/actions black formatting routine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants