Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor output classes #127

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Refactor output classes #127

merged 3 commits into from
Dec 12, 2023

Conversation

liamhuber
Copy link
Member

Instead of instantiating the data classes, just always use the class directly. This removes the need for one misdirection layer.

@liamhuber
Add a better interface than call
2d9b389 
Now we can always just use the class directly
@liamhuber
Purge instances of the dataclasses
24f1ae2 
This also removes the misdirection layer
@liamhuber
Give the classes shorter names
9c328b0
jan-janssen
jan-janssen approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@liamhuber liamhuber merged commit c74980b into output_modul Dec 12, 2023
2 checks passed
@liamhuber liamhuber deleted the lrefactor_output branch December 12, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamhuber @jan-janssen