Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Coveralls Github action #53

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Use Coveralls Github action #53

merged 1 commit into from
Oct 11, 2023

Conversation

jan-janssen
Copy link
Member

No description provided.

@liamhuber
Copy link
Member

Awesome, thanks! Today I'll point one of the repos to this commit to make sure it's working as intended, then merge as long as everything works as expected.

@jan-janssen
Copy link
Member Author

Awesome, thanks! Today I'll point one of the repos to this commit to make sure it's working as intended, then merge as long as everything works as expected.

Is it possible to have unit tests for this repository? So we can see if changes to the actions have the correct effects.

@liamhuber
Copy link
Member

Awesome, thanks! Today I'll point one of the repos to this commit to make sure it's working as intended, then merge as long as everything works as expected.

Is it possible to have unit tests for this repository? So we can see if changes to the actions have the correct effects.

Probably? But I'm not sure. Somethings for sure would be hard to test that way, as the intent is to use these as reusable workflows, but github forces us to store them in .github/workflows so I don't know what the interaction would be between writing the workflows and having them run on the repo holding them.

I like the idea, I think it has a high probability of working, but I don't have the time to prioritize experimenting with it right now.

@liamhuber
Copy link
Member

Beautiful, worked perfectly over on pyiron_ontology.

I poked in and it's definitely running the new command too:
Screen Shot 2023-10-11 at 11 37 21

@liamhuber liamhuber merged commit a4901bd into main Oct 11, 2023
@liamhuber liamhuber deleted the coveralls branch October 11, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants