Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] run black on the whole repository #138

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[major] run black on the whole repository #138

merged 1 commit into from
Jan 7, 2025

Conversation

XzzX
Copy link
Contributor

@XzzX XzzX commented Dec 18, 2024

Formatting the whole repository should be the default. Exclusion of files and directories should be the exception. Not the other way round. Files and directories can be excluded via pyproject.toml:

[tool.black]
extend-exclude = ''' 
(
  ^/docs
)
'''

run black on the whole project by default
@XzzX XzzX requested a review from niklassiemer December 18, 2024 08:43
@liamhuber liamhuber changed the title run black on the whole repository [major] run black on the whole repository Dec 19, 2024
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pyiron_workflow and pyiron_module_template have PRs making them ready to go -- for the rest, we can patch any black failures when they update to targeting a version of pyiron/actions that includes this PR.

@liamhuber liamhuber merged commit b56a20c into main Jan 7, 2025
@liamhuber liamhuber deleted the XzzX-patch-1 branch January 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants