Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1 has no decorator #935

Closed
nhumrich opened this issue Apr 28, 2023 · 3 comments
Closed

2.1 has no decorator #935

nhumrich opened this issue Apr 28, 2023 · 3 comments

Comments

@nhumrich
Copy link

Using the latest fabric and invoke, and fabric is broken due to invoke 2.1.0. The decorator package can't be found or imported by fabric.

Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.10.11/lib/python3.10/site-packages/fabric/connection.py", line 7, in <module>
    from invoke.vendor.decorator import decorator
ModuleNotFoundError: No module named 'invoke.vendor.decorator'
@cemkavuklu
Copy link

Experiencing the same issue.
invoke.vendor.decorator was deleted in #906 but going through the PR conversation, the reason is not obvious to me.
Some clarification would be much appreciated.

@bitprophet
Copy link
Member

Yea, I'm not sure @kuwv ever gave a rationale in #906 for why that was removed, and I neglected to follow up on that point before merging.

OTOH this is also arguably bad hygiene on Fabric's part, so I think it's proper to fix it there instead. Fabric will be getting a 3.1 release relatively soon and that feels like the right spot to "add" a "new" dependency. I'll go commit this over there so it's not forgotten.

dskard added a commit to rstudio/checkrs-tew that referenced this issue May 16, 2023
it is a dependency of `invoke`, which is a dependency of `fabric`. in
the 2.1.0 version `invoke`, the `decorator` package was removed. the
reason is not clear, but the `invoke` package maintainer plans to add it
back in for one of the 3.x versions.

more infor at pyinvoke/invoke#935
@kuwv
Copy link
Contributor

kuwv commented Jun 18, 2023

@bitprophet yeah I removed it because at the time it wasn't used within invoke. I cleaned it up without knowing it would affect fabric.

My apologies all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants