-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve state of the art for screenshot testing #555
Conversation
ecd2e81
to
0c15dc9
Compare
hmm i guess i need to take WPGU_FORCE_OFFSCREEN a little further too. |
0c15dc9
to
03b30e4
Compare
@hmaarrfk you want me to merge this or does it need some work? |
i think this is fine as is right? I'm not sure if the testing was improved since Aug 24, but i just wanted to keep them in sync. that is finding the "small difference" and the tuning parameters for the tolerance. |
ohhh with this comment... |
yeah give me som etime... you know... one day.. |
I think i remember my concern. there was an other very similar environment variable in this project, and I needed time to figure out the interaction (and I still need time to do so) |
48a19cf
to
ca97186
Compare
Ok at the time, I just had a hard time choosing a variable name. I think I didn't want to propagate the documentation of 3 variables:
Anyway, corrupting an example and running the new instructions in the readme yields: |
ca97186
to
ee33aa0
Compare
needless to say, #659 needs to be resolved first |
279f99e
to
e104eb8
Compare
to test locally
e104eb8
to
8e305a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @almarklein I'll let you merge if you're okay too.
port of pygfx/pygfx#827