Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve state of the art for screenshot testing #555

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

hmaarrfk
Copy link
Contributor

port of pygfx/pygfx#827

@hmaarrfk hmaarrfk force-pushed the better_local_testing branch from ecd2e81 to 0c15dc9 Compare August 25, 2024 05:08
@hmaarrfk hmaarrfk marked this pull request as ready for review August 25, 2024 05:08
@hmaarrfk hmaarrfk requested a review from Korijn as a code owner August 25, 2024 05:08
@hmaarrfk
Copy link
Contributor Author

hmm i guess i need to take WPGU_FORCE_OFFSCREEN a little further too.

@Korijn Korijn force-pushed the better_local_testing branch from 0c15dc9 to 03b30e4 Compare December 29, 2024 19:41
@Korijn
Copy link
Collaborator

Korijn commented Dec 29, 2024

@hmaarrfk you want me to merge this or does it need some work?

@hmaarrfk
Copy link
Contributor Author

i think this is fine as is right?

I'm not sure if the testing was improved since Aug 24, but i just wanted to keep them in sync. that is finding the "small difference" and the tuning parameters for the tolerance.

@hmaarrfk
Copy link
Contributor Author

hmm i guess i need to take WPGU_FORCE_OFFSCREEN a little further too.

ohhh with this comment...

@hmaarrfk
Copy link
Contributor Author

yeah give me som etime... you know... one day..

@hmaarrfk
Copy link
Contributor Author

I think i remember my concern. there was an other very similar environment variable in this project, and I needed time to figure out the interaction (and I still need time to do so)

@hmaarrfk hmaarrfk force-pushed the better_local_testing branch 2 times, most recently from 48a19cf to ca97186 Compare December 30, 2024 01:04
@hmaarrfk
Copy link
Contributor Author

Ok at the time, I just had a hard time choosing a variable name.

I think I didn't want to propagate the documentation of 3 variables:

  • WGPU_ADAPTER_NAME (which doesnt seem to work)
  • PYGFX_WGPU_ADAPTER_NAME -- pygfx only
  • WGPUPY_WGPU_ADAPTER_NAME wgpu, so I guess pygfx can use this (this is likely where I got stuck mentally)

Anyway, corrupting an example and running the new instructions in the readme yields:

image

@hmaarrfk hmaarrfk force-pushed the better_local_testing branch from ca97186 to ee33aa0 Compare December 30, 2024 01:08
@hmaarrfk hmaarrfk marked this pull request as draft December 30, 2024 01:08
@hmaarrfk
Copy link
Contributor Author

needless to say, #659 needs to be resolved first

@hmaarrfk hmaarrfk force-pushed the better_local_testing branch 2 times, most recently from 279f99e to e104eb8 Compare December 30, 2024 01:24
@hmaarrfk hmaarrfk marked this pull request as ready for review December 30, 2024 12:24
@hmaarrfk hmaarrfk force-pushed the better_local_testing branch from e104eb8 to 8e305a0 Compare December 30, 2024 13:39
README.md Outdated Show resolved Hide resolved
wgpu/backends/wgpu_native/_api.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Korijn Korijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @almarklein I'll let you merge if you're okay too.

@almarklein almarklein merged commit 8a0b267 into pygfx:main Jan 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants