Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to wgpu-native v0.18.1.1 #429

Merged
merged 21 commits into from
Nov 23, 2023
Merged

Update to wgpu-native v0.18.1.1 #429

merged 21 commits into from
Nov 23, 2023

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Nov 20, 2023

closes #352

  • Update the header files.
  • Run codegen, fix parsing.
  • Handle fixme's.
  • Refactor canvas context, removing swap chain concepts in favor of wgpuSurfaceXX (check all).
  • use new WGPUCompositeAlphaMode?
  • What is FifoRelaxed present mode?
  • Update tests and examples
  • Fix that CanvasContext's don't clean up properly.
  • Some calls can pass null pointer, check WGPU_NULLABLE and check for it. that nullable texture only applied to that particular situation, and we've got that covered.
  • Check Device objects are not cleared on wgpu-native #405 -> nope, still leaks
  • Check [Qt, Windows] Crash when switching from monitor to monitor with different DPI values #352 -> yes!
  • Update release notes.
  • Prepare a pygfx PR: Adjust to new wgpu-py pygfx#617
    • Adjust to API changes
    • Perhaps shader changes. Not needed
    • Can we use features like Float32Filterable rather than WGPUNativeFeature_TextureAdapterSpecificFormatFeatures -> not yet

After this is merged:

  • Release wgpu-py.
  • Merge pygfx-pr, and release pygfx.

@almarklein
Copy link
Member Author

As for #352, it looks like the warnings (when dragging a window from one monitor to another on Windows+Qt) cannot be avoided without breaking window resizing on other systems. Nevertheless, the window is not in a broken state anymore where a resize is needed to get it working again. In other words, the error messages are annoying but otherwise harmless.

@almarklein
Copy link
Member Author

almost done now 😅

@almarklein almarklein mentioned this pull request Nov 23, 2023
2 tasks
@almarklein
Copy link
Member Author

Can we use features like Float32Filterable rather than WGPUNativeFeature_TextureAdapterSpecificFormatFeatures

The reason why I want this is that the latter is a native-only feature (not part of the webgpu spec). This means that using it also unlocks other stuff, and accidentally using that may cause downstream code to become incompatible with WebGPU.

I tried adding it to wgpu-native (gfx-rs/wgpu-native#322), but the feature is simply not implemented in wgpu-core yet. I'm looking into adding it there, but it will take some time before that lands in a new wgpu-native release.

@almarklein almarklein marked this pull request as ready for review November 23, 2023 11:31
@almarklein almarklein requested a review from Korijn as a code owner November 23, 2023 11:31
@almarklein
Copy link
Member Author

Fixed the pypy memytest with another well-placed gc.collect 😉

CHANGELOG.md Outdated Show resolved Hide resolved
@almarklein almarklein merged commit 7b65d04 into main Nov 23, 2023
19 checks passed
@almarklein almarklein deleted the update-native branch November 23, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Qt, Windows] Crash when switching from monitor to monitor with different DPI values
2 participants