-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu-native v0.14.2.3 #329
Conversation
I went over your work so far and didn't see anything out of the ordinary. |
This is close to finished, but I'm stuck on an error related to uploading 3D texture data. I'm starting to think this might be a bug in wgpu-core.
|
Having some trouble getting it to work in pygfx, related to validations failing for depth-stencil:
|
PyGfx is up and running! 🚀 But ... Sigh ... now the wheel building fails: "This does not look like a platform wheel" |
Nevermind, fixed it. |
Ready from my end! |
So, it didn't fail silently! That's a good thing. :) Good job! |
Well, the Linux build was the only one that failed. For some reason the Windows and MacOS build passed, even though they suffered from the same problem. |
From scanning the changes in the .h files:
WGPUProcComputePassEncoderDispatch
->WGPUProcComputePassEncoderDispatchWorkgroups
WGPUProcComputePassEncoderDispatchIndirect
wgpuFree
. Not for logging. But needed for result ofwgpuSurfaceGetSupportedFormats
andwgpuSurfaceGetSupportedPresentModes
.wgpuRenderPassEncoderDrop
,wgpuSurfaceDrop
, and more drop functions.Other tasks:
Copy from the changelog:
min_binding_size
increate_bind_group_layout
, it should beNone
instead of zero.stencil_read_mask
andstencil_write_mask
fields in theDepthStencilState
struct passed tocreate_render_pipeline()
must be set to 0.@stage(compute)
must now be@compute
. Same forvertex
andfragment
.mod
,matrix
andref
.smoothStep
is nowsmoothstep
.