Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IDL #327

Merged
merged 15 commits into from
Jan 14, 2023
Merged

Update IDL #327

merged 15 commits into from
Jan 14, 2023

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Jan 12, 2023

Update to the latest webgpu.idl, which may affect the API.

The eventual API changes are minimal this time.

  • Texture has new props weight, height, depth_or_array_layers
  • Buffer has new prop map_state

The IDL does move get_preferred_format to the global GPU object, but we need to have it on the canvas context, because we have different types of canvases. So in the end this did not result in a change 🤷

@almarklein almarklein mentioned this pull request Jan 12, 2023
36 tasks
@almarklein almarklein marked this pull request as ready for review January 13, 2023 00:09
@almarklein almarklein requested a review from Korijn as a code owner January 13, 2023 00:09
Copy link
Collaborator

@Korijn Korijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@almarklein
Copy link
Member Author

I'll merge this once I've made sure that PyGfx works with the update too.

@almarklein almarklein merged commit bbbd636 into main Jan 14, 2023
@almarklein almarklein deleted the idl branch January 14, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants