new_design: Alternate proof formulation, maybe more readable? #10
+41
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Jul 28, 2020
Comment on lines
+99
to
+100
| def sqr {α : Type u} [has_mul α] (x : α) := x*x | ||
| local postfix `²`:80 := sqr |
There was a problem hiding this comment.
This avoids the nasty lambda functions in the expressions, and shows ² in the tactic state for as long as possible.
eric-wieser
commented
Jul 28, 2020
| (fₛ : K →+* G) | ||
| (fᵥ : V →+ G) | ||
| (fᵥ : V →ₗ[K] G) |
There was a problem hiding this comment.
I think this is more restrictive, and possibly more correct?
eric-wieser
commented
Jul 28, 2020
| @@ -86,49 +94,54 @@ variables (K : Type u) [field K] | |||
|
|
|||
| variables (V : Type u) [add_comm_group V] [vector_space K V] | |||
|
|
|||
| structure GA | |||
| (G : Type u) | |||
| [ring G] extends algebra K G := | |||
There was a problem hiding this comment.
Apparently extends is a terrible idea if the target has fewer arguments than the currently declared type
eric-wieser
force-pushed
the
eric-wieser/new_design
branch
from
418a441 to
98a41b9
Compare
eric-wieser
commented
Jul 28, 2020
Comment on lines
+122
to
+123
| set a := ga.fᵥ aᵥ, | ||
| set b := ga.fᵥ bᵥ, |
There was a problem hiding this comment.
This seems like a super handy command to remember
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to take bits piecewise