Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs Webhook failure #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trundev
Copy link
Contributor

@trundev trundev commented Dec 12, 2024

This is to fix the annoying failure when creating PRs.

The "readthedocs" server, seems to require a build.os parameters, as answered here.

I changed the Python version to 3.9, just to have a longer live-span (it needed to drop sphinx version limit).
Migration to a later python version need more work, not sure if this is really needed.

In addition, the now obsolete numba~=0.48.0 note can be removed from here: https://clifford.readthedocs.io/en/latest/installation.html#pypi

Add 'build.os' config value as suggested in readthedocs#11173.
Use python 3.9, as it is the latest version that works - needs removal
of the 'sphinx' version limit.
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.15%. Comparing base (568087f) to head (af82858).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   71.13%   71.15%   +0.02%     
==========================================
  Files          74       74              
  Lines        9437     9437              
  Branches     1211     1211              
==========================================
+ Hits         6713     6715       +2     
+ Misses       2551     2548       -3     
- Partials      173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trundev trundev marked this pull request as ready for review December 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant