Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numba: inverse functions, layout attributes, and better constructors #412

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 13, 2021

This adds numba extension support for:

  • A handful of MultiVector methods and attributes via straightforward wrappers.
    Within these, we only do if isinstance(self, MultiVectorType): in the functions where we rely on the existence of self.layout_type.
  • Some Layout attributes via straightforward wrappers.
  • The dtype argument to MultiVector

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #412 (61e373e) into master (a7a5407) will increase coverage by 0.22%.
The diff coverage is 90.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   71.13%   71.35%   +0.22%     
==========================================
  Files          73       73              
  Lines        9326     9454     +128     
  Branches     1205     1211       +6     
==========================================
+ Hits         6634     6746     +112     
- Misses       2526     2538      +12     
- Partials      166      170       +4     
Impacted Files Coverage Δ
clifford/numba/__init__.py 100.00% <ø> (ø)
clifford/numba/_multivector.py 73.53% <80.00%> (+0.51%) ⬆️
clifford/numba/_layout.py 94.20% <80.95%> (-3.84%) ⬇️
clifford/_layout.py 96.95% <100.00%> (+0.93%) ⬆️
clifford/test/test_numba_extensions.py 100.00% <100.00%> (ø)
clifford/tools/g3c/object_clustering.py 64.28% <0.00%> (-2.05%) ⬇️
clifford/test/test_g3c_tools.py 81.84% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a5407...61e373e. Read the comment docs.

@eric-wieser eric-wieser changed the title numba: add support for inverse functions numba: inverse functions, layout attributes, and better constructors Aug 13, 2021
Copy link
Member

@hugohadfield hugohadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful and sensible, and all the tests pass

@eric-wieser eric-wieser merged commit 9e8fcf2 into pygae:master Aug 30, 2021
@zevisert zevisert mentioned this pull request Feb 3, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants