HeteroData.subgraph()
#4635
Merged
HeteroData.subgraph()
#4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4635 +/- ##
==========================================
+ Coverage 82.93% 82.96% +0.03%
==========================================
Files 316 316
Lines 16750 16773 +23
==========================================
+ Hits 13891 13916 +25
+ Misses 2859 2857 -2
Continue to review full report at Codecov.
|
Padarn
reviewed
May 13, 2022
Padarn
reviewed
May 13, 2022
torch_geometric/data/hetero_data.py
Outdated
| ) | ||
|
|
||
| Args: | ||
| subset (Dict[str, Tensor or BoolTensor]): A dictonary holding the |
There was a problem hiding this comment.
Do you think its worth allowing also List[str] when you just want to filter node types out?
There was a problem hiding this comment.
Good idea. Let's do this in a separate PR since I am not sure we want to re-use subgraph for this due its expensive re-labeling computation.
Padarn
reviewed
May 13, 2022
rusty1s
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4001.
This PR adds
subgraphtoHeteroData.