Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'wiki' dataset to LINKXDataset #4600

Merged
merged 9 commits into from
May 9, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented May 7, 2022

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #4600 (8395cba) into master (9a16a0e) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4600      +/-   ##
==========================================
- Coverage   82.91%   82.80%   -0.12%     
==========================================
  Files         315      315              
  Lines       16596    16599       +3     
==========================================
- Hits        13760    13744      -16     
- Misses       2836     2855      +19     
Impacted Files Coverage Δ
torch_geometric/data/download.py 100.00% <100.00%> (ø)
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/io/tu.py 93.58% <0.00%> (-2.57%) ⬇️
torch_geometric/nn/models/mlp.py 98.41% <0.00%> (-1.59%) ⬇️
torch_geometric/transforms/gdc.py 78.17% <0.00%> (-1.02%) ⬇️
torch_geometric/data/dataset.py 96.80% <0.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/rgat_conv.py 83.76% <0.00%> (-0.53%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a16a0e...8395cba. Read the comment docs.

@@ -34,6 +38,11 @@ def download_url(url: str, folder: str, log: bool = True):
data = urllib.request.urlopen(url, context=context)

with open(path, 'wb') as f:
f.write(data.read())
# workaround for https://bugs.python.org/issue42853
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better solution here might be to upload the file in smaller chunks

torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
@rusty1s rusty1s changed the title Adding 'wiki' dataset to LINKXDataset Adding 'wiki' dataset to LINKXDataset May 9, 2022
@rusty1s rusty1s merged commit cd6c1f7 into pyg-team:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants