Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singularity image #4376

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Conversation

NucciTheBoss
Copy link
Contributor

Purpose

Pull request fixes tzdata data-entry issue brought up in issue #4365.

Changelog

  1. Set timezone to Etc/UTC to make tzdata data-entry prompt go away.
  2. Updated base image to nvidia/cuda:10.1-cudnn7-devel-ubuntu18.04. g++ was too old to compile numpy in the old base image.
  3. Removed make in apt-get install -y --no-install-recommends. make is provided by the build-essential package.
  4. Added missing dependencies to apt-get install -y --no-install-recommends. Needed gfortran, liblapack-dev, libopenblas-dev, and libhdf5-dev.
  5. Added some code styling to build recipe.

Testing

Had some of the consultants I work with run tests on our cluster. Did not encounter any runtime errors.

What's next

Updating Dockerfile and singularity recipe to newer version of pytorch_geometric.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #4376 (1bc38be) into master (d451d6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4376   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files         309      309           
  Lines       16017    16017           
=======================================
  Hits        13220    13220           
  Misses       2797     2797           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d451d6d...1bc38be. Read the comment docs.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could upgrade to a reasonable PyTorch version in a later PR.

docker/singularity Show resolved Hide resolved
@NucciTheBoss
Copy link
Contributor Author

Added explanation comment for setting timezone to recipe. Should be good to go.

@rusty1s
Copy link
Member

rusty1s commented Mar 31, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants