Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sampler): support empty num_neighbors_dict #99

Merged
merged 14 commits into from
Sep 9, 2022
Merged

fix(sampler): support empty num_neighbors_dict #99

merged 14 commits into from
Sep 9, 2022

Conversation

mananshah99
Copy link
Contributor

No description provided.

@mananshah99 mananshah99 self-assigned this Sep 9, 2022
@mananshah99 mananshah99 requested review from rusty1s and a team September 9, 2022 01:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #99 (88f5bd8) into master (23790c3) will decrease coverage by 0.08%.
The diff coverage is 75.00%.

❗ Current head 88f5bd8 differs from pull request most recent head 85c6932. Consider uploading reports for the commit 85c6932 to get more accurate results

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   78.88%   78.79%   -0.09%     
==========================================
  Files          16       16              
  Lines         412      415       +3     
==========================================
+ Hits          325      327       +2     
- Misses         87       88       +1
Impacted Files Coverage Δ
pyg_lib/csrc/sampler/cpu/neighbor_kernel.cpp 58.92% <75.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mananshah99 mananshah99 mentioned this pull request Sep 9, 2022
Merged
@rusty1s rusty1s merged commit 036e891 into master Sep 9, 2022
@rusty1s rusty1s deleted the fix_empty_num_nodes branch September 9, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s left review comments

Assignees

@mananshah99 mananshah99

Labels
0 - Priority P0 bug sampler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mananshah99 @codecov-commenter @rusty1s