Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for calculating Makkink reference evaporation same as KNMI #49

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Add method for calculating Makkink reference evaporation same as KNMI #49

merged 3 commits into from
Feb 22, 2023

Conversation

martinvonk
Copy link
Contributor

The Royal Netherlands Meteorological Institute (KNMI) has slightly different formula for calculating Makkink reference evaporation than currently implemented in pyet. Note that this method is only applicable to the Netherlands (~sea level). Calculating the Makkink evaporation with the formula from Makkink (1957) is more suitable for general purposes.

@martinvonk
Copy link
Contributor Author

If you want I can add this method to calculate_all function such that it is tested. However, maybe you want to test is seperately since you already have regular makkink.

pyet/radiation.py Outdated Show resolved Hide resolved
and remove rounding by 1 decimal as default
@mvremec mvremec merged commit 8173537 into pyet-org:dev Feb 22, 2023
@mvremec
Copy link
Contributor

mvremec commented Feb 22, 2023

Thank you for this implementation Martin, and welcome to the PyEt family!

@martinvonk martinvonk deleted the makkink_knmi branch February 23, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants