Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 196 #227

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Issue 196 #227

merged 3 commits into from
Jul 2, 2024

Conversation

manulera
Copy link
Collaborator

@manulera manulera commented May 13, 2024

Closes #196. A few additions to make contributing a bit easier.

  • The first commit includes pre-commit and other linting dependencies as dev dependencies and includes documentation on how to install pre-commit hooks.
  • The second commit includes files for vscode users, that:
    • Recommend extensions
    • Tell vscode where to find the virtual environment, flake8 and black to display the intellisense and linting in the IDE
  • The second commit also includes poetry.toml. This file sets virtualenvs.in-project = true for poetry, making it create the virtual environment at .venv, which should be the default.

@manulera manulera changed the base branch from master to dev_bjorn May 13, 2024 10:11
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (6bbfdfc) to head (01c17ef).
Report is 5 commits behind head on dev_bjorn.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_bjorn     #227   +/-   ##
==========================================
  Coverage      93.64%   93.64%           
==========================================
  Files             40       40           
  Lines           3854     3855    +1     
  Branches         573      573           
==========================================
+ Hits            3609     3610    +1     
  Misses           196      196           
  Partials          49       49           

@manulera
Copy link
Collaborator Author

Let me know what you think @BjornFJohansson

@manulera
Copy link
Collaborator Author

Hi @BjornFJohansson following up on this. Can you review this PR?

@BjornFJohansson BjornFJohansson merged commit 7da9281 into dev_bjorn Jul 2, 2024
34 checks passed
@BjornFJohansson BjornFJohansson deleted the issue_196 branch July 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants