Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: drop python 3.7 support #299

Closed
DanAlbert opened this issue May 10, 2023 · 2 comments · Fixed by #327
Closed

RFC: drop python 3.7 support #299

DanAlbert opened this issue May 10, 2023 · 2 comments · Fixed by #327

Comments

@DanAlbert
Copy link
Collaborator

Python 3.8 adds functools.cached_property which would be nice for cleaning up some lazily initialized globals like PayloadDirectories and probably LiveryScanner.

Is anyone still relying on 3.7 support? That version of Python is EOL in about a month and a half, so I hope not.
@mkosmo
Copy link

mkosmo commented May 30, 2023

Python 3.7 goes EoL in less than a month (2023-06-27). I'd recommend keeping ahead of the python support schedule.

@DanAlbert
Copy link
Collaborator Author

No one seems to mind and I want typing.Literal for #326, so will send a PR for this momentarily.

DanAlbert added a commit to DanAlbert/dcs that referenced this issue Jul 20, 2023
@DanAlbert
Drop Python 3.7 support.
de0de4c 
Past EOL.

Fixes pydcs#299.
DanAlbert added a commit to DanAlbert/dcs that referenced this issue Jul 20, 2023
@DanAlbert
Drop Python 3.7 support.
569bfb4 
Past EOL.

Fixes pydcs#299.
@DanAlbert DanAlbert mentioned this issue Jul 20, 2023
Merged
DanAlbert added a commit to DanAlbert/dcs that referenced this issue Jul 20, 2023
@DanAlbert
Drop Python 3.7 support.
ec0f170 
Past EOL.

Fixes pydcs#299.
@DanAlbert DanAlbert mentioned this issue Jul 20, 2023
Open
DanAlbert added a commit that referenced this issue Jul 20, 2023
@DanAlbert
Drop Python 3.7 support.
d0c80e1 
Past EOL.

Fixes #299.
Raffson pushed a commit to dcs-retribution/pydcs that referenced this issue Oct 1, 2023
@DanAlbert @Raffson
Drop Python 3.7 support.
08fc2d9 
Past EOL.

Fixes pydcs#299.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Python 3.7 support. DanAlbert/dcs
2 participants
@mkosmo @DanAlbert