New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split out CFDatetimeCoder, deprecate use_cftime as kwarg #9901

Open

kmuehlbauer wants to merge 7 commits into pydata:main from kmuehlbauer:coders

+190 −53

Contributor

kmuehlbauer commented Dec 17, 2024 •

edited

Loading

Tests added
User visible changes (including notable bug fixes) are documented in whats-new.rst
New functions/methods are listed in api.rst

This makes something like this possible:

import xarray as xr
from xarray.coders import CFDatetimeCoder
# available with this PR
ds = xr.open_mfdataset(..., decode_times=CFDatetimeCoder(use_cftime=True))
# available with #9618
ds = xr.open_mfdataset(..., decode_times=CFDatetimeCoder(time_unit="s"))

kmuehlbauer added 2 commits

December 17, 2024 16:46


          split out CFDatetimeCoder into coders, deprecate use_cftime as keywor…

a2d8e69

…d argument


          add whats-new.rst entry

d6fe956

kmuehlbauer marked this pull request as ready for review

December 17, 2024 15:54

kmuehlbauer mentioned this pull request

Relax nanosecond datetime restriction in CF time decoding #9618

Open

9 tasks

dcherian reviewed

View reviewed changes

doc/whats-new.rst Outdated Show resolved Hide resolved

dcherian reviewed

View reviewed changes

doc/whats-new.rst Show resolved Hide resolved

dcherian reviewed

View reviewed changes

xarray/backends/api.py Outdated Show resolved Hide resolved

dcherian reviewed

View reviewed changes

xarray/backends/api.py Outdated Show resolved Hide resolved

dcherian reviewed

View reviewed changes

xarray/conventions.py Outdated Show resolved Hide resolved

dcherian reviewed

View reviewed changes

Contributor

dcherian left a comment

I like this but since this is adding public API, can you open an issue and see if everyone is on board please

kmuehlbauer commented

View reviewed changes

doc/whats-new.rst Outdated Show resolved Hide resolved

kmuehlbauer commented

View reviewed changes

xarray/backends/api.py Outdated Show resolved Hide resolved

kmuehlbauer and others added 3 commits

December 17, 2024 17:19


          Apply suggestions from code review

bd6a5d1

Co-authored-by: Deepak Cherian <[email protected]>


          [pre-commit.ci] auto fixes from pre-commit.com hooks

6557ef9

for more information, see https://pre-commit.ci


          fix warning

759fb72

kmuehlbauer mentioned this pull request

Group together decoding options into a single argument #4490

Open

kmuehlbauer added 2 commits

December 17, 2024 17:53


          fix docstrings


          try fix typing

262295a

Contributor Author

kmuehlbauer commented Dec 17, 2024

@dcherian Thanks for reviewing, addressed along your comments/suggestions. I've added a comment to #4490 for more visibility, hope that's sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet