-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize idxmin, idxmax with dask #9800
Open
dcherian
wants to merge
11
commits into
pydata:main
Choose a base branch
from
dcherian:vindex-idxminmax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+115
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
added
the
topic-chunked-arrays
Managing different chunked backends, e.g. dask
label
Nov 20, 2024
headtr1ck
reviewed
Nov 20, 2024
dcherian
force-pushed
the
vindex-idxminmax
branch
from
November 21, 2024 03:43
a4ba2bc
to
9152b6f
Compare
dcherian
force-pushed
the
vindex-idxminmax
branch
from
December 3, 2024 18:20
4431b2e
to
6f47c5b
Compare
dcherian
force-pushed
the
vindex-idxminmax
branch
from
December 3, 2024 18:27
826fed4
to
9cf0157
Compare
dcherian
force-pushed
the
vindex-idxminmax
branch
from
December 6, 2024 15:49
fa4060b
to
01d9951
Compare
Merging on Thursday if there are no comments |
headtr1ck
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, never submitted my review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
plan to merge
Final call for comments
topic-chunked-arrays
Managing different chunked backends, e.g. dask
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
api.rst
cc @phofl here we need to index a numpy array with a dask array (commonly a much larger array) in a sane manner.
We now preserve chunksizes for
After
Before