Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch to Dask if nanquantile is available #9719

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

phofl
Copy link
Contributor

@phofl phofl commented Nov 5, 2024

This won't get hit until the next Dask release is out, but it passes locally with the dev version of Dask

@phofl
Copy link
Contributor Author

phofl commented Nov 5, 2024

cc @dcherian

@dcherian dcherian changed the title Dispatch to Dask is nanquantile is available Dispatch to Dask if nanquantile is available Nov 5, 2024
@max-sixty max-sixty added the run-upstream Run upstream CI label Nov 5, 2024
@phofl
Copy link
Contributor Author

phofl commented Nov 5, 2024

The upstream tag is handy!

The failures all look related to zarr or pandas. that said, dask isn't tagged with 2024.11.0 yet, so the tests aren't hit yet until we actually cut the release unfortunately

@phofl
Copy link
Contributor Author

phofl commented Nov 9, 2024

this should be ready now, dask was released today

@dcherian dcherian merged commit 6df8bd6 into pydata:main Nov 9, 2024
27 of 29 checks passed
@phofl phofl deleted the quantile-dispatch branch November 9, 2024 12:58
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 9, 2024
* main:
  Compress PNG files (pydata#9747)
  Dispatch to Dask if nanquantile is available (pydata#9719)
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 19, 2024
* main:
  fix html repr indexes section (pydata#9768)
  Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (pydata#9763)
  unpin array-api-strict, as issues are resolved upstream (pydata#9762)
  rewrite the `min_deps_check` script (pydata#9754)
  CI runs ruff instead of pep8speaks (pydata#9759)
  Specify copyright holders in main license file (pydata#9756)
  Compress PNG files (pydata#9747)
  Dispatch to Dask if nanquantile is available (pydata#9719)
  Updates to Dask page in Xarray docs (pydata#9495)
  http:// → https:// (pydata#9748)
  Discard useless `!s` conversion in f-string (pydata#9752)
  Apply ruff/flake8-simplify rule SIM401 (pydata#9749)
  Use micromamba 1.5.10 where conda is needed (pydata#9737)
  pin array-api-strict<=2.1 (pydata#9751)
  Reorganise ruff rules (pydata#9738)
  use new conda-forge package pydap-server (pydata#9741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-upstream Run upstream CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataArray.quantile is very slow for Dask applications (and generally)
3 participants