Bump minimum versions for dependencies #9434
Conversation
dcherian
force-pushed
the
bump-min-versions
branch
from
c482a7e to
a755cff
Compare
| # h5py and hdf5 tend to cause conflicts | ||
| # for e.g. hdf5 1.12 conflicts with h5py=3.1 | ||
| # prioritize bumping other packages instead | ||
| - h5py=3.8 | ||
| - hdf5=1.12 | ||
| - hypothesis | ||
| - iris=3.4 | ||
| - iris=3.7 | ||
| - lxml=4.9 # Optional dep of pydap | ||
| - matplotlib-base=3.7 | ||
| - nc-time-axis=1.4 | ||
| # netcdf follows a 1.major.minor[.patch] convention | ||
| # (see https://github.com/Unidata/netcdf4-python/issues/1090) | ||
| - netcdf4=1.6.0 |
There was a problem hiding this comment.
in theory we can also bump to netcdf4=1.6.4. This would mean that we don't support any version that is not affected by the race conditions, though, so not sure if we should do that.
There was a problem hiding this comment.
we don't support any version that is not affected by the race conditions, though
hmmm I am not so sure.
Co-authored-by: Justus Magin <[email protected]>
This reverts commit ae285b1.
|
Merging. We could potentially bump netcdf4, and h5py in a future PR. |
|
Does anyone happen to know off-hand why the numbagg min version didn't bump? I can look more unless someone can immediately see https://pypi.org/project/numbagg/#history — most recent version released 12 months ago was 0.2.2, released on 2023-01-04, while this specifies 0.2.1. We get big progression & xarray code simplification over the next six weeks, when we get to 12 months since 0.6.0 |
I think it's ok to be a little loose on this timeline if the benefits are large. |
|
we didn't teach the min-versions script to understand |
OK thanks (my first thought is "isn't |
|
only if you consider In any case, it may be worth looking for a way to tell the script that certain libraries follow a |
This would work OK, no? If |
|
it confuses the script, and thus explicitly marks this as an error. We can totally change that, but someone would have to do this (and I won't have time for the next two weeks). |
|
I took a look at the script (though I can't run it without installing conda...), and I think it's ignoring patch versions, which is totally fine. (I thought the discussion above meant that it was somehow handling Assuming that's correct, |
|
as long as we specify the patch version, the script won't do anything. It will only work correctly we pin I still think it's worth changing the script to allow special-casing certain packages (as in, |
* main: (29 commits) Release notes for v2024.09.0 (pydata#9480) Fix `DataTree.coords.__setitem__` by adding `DataTreeCoordinates` class (pydata#9451) Rename DataTree's "ds" and "data" to "dataset" (pydata#9476) Update DataTree repr to indicate inheritance (pydata#9470) Bump pypa/gh-action-pypi-publish in the actions group (pydata#9460) Repo checker (pydata#9450) Add days_in_year and decimal_year to dt accessor (pydata#9105) remove parent argument from DataTree.__init__ (pydata#9465) Fix inheritance in DataTree.copy() (pydata#9457) Implement `DataTree.__delitem__` (pydata#9453) Add ASV for datatree.from_dict (pydata#9459) Make the first argument in DataTree.from_dict positional only (pydata#9446) Fix typos across the code, doc and comments (pydata#9443) DataTree should not be "Generic" (pydata#9445) Disallow passing a DataArray as data into the DataTree constructor (pydata#9444) Support additional dtypes in `resample` (pydata#9413) Shallow copy parent and children in DataTree constructor (pydata#9297) Bump minimum versions for dependencies (pydata#9434) Always include at least one category in random test data (pydata#9436) Avoid deep-copy when constructing groupby codes (pydata#9429) ...
* Bump minimum dependency versions Closes pydata#9363 * Update doc/whats-new.rst Co-authored-by: Justus Magin <[email protected]> * bump netcdf4 * fix rtd * Revert "bump netcdf4" This reverts commit ae285b1. --------- Co-authored-by: Justus Magin <[email protected]>
whats-new.rst