Use EllipsisType #9418
Merged
Use EllipsisType #9418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a few things: - Upgrades mypy - Adds lots of ignores for mpl & pandas type issues in tests -- not as good as fixing them, but better than staying on mypy 1.8 - Removes some old ignores - Adds a couple of ignores with notes where it's our issue and I'm not sure what's going on - Starts using the `EllipsisType` in a couple of places Note that I used a tool to mass-add ignores, I didn't add them all manually
Now with python3.10 we can roll this out. Stacks on pydata#9417, merge that first
for more information, see https://pre-commit.ci
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* Upgrade mypy to 1.11 This does a few things: - Upgrades mypy - Adds lots of ignores for mpl & pandas type issues in tests -- not as good as fixing them, but better than staying on mypy 1.8 - Removes some old ignores - Adds a couple of ignores with notes where it's our issue and I'm not sure what's going on - Starts using the `EllipsisType` in a couple of places Note that I used a tool to mass-add ignores, I didn't add them all manually * Use `EllipsisType` Now with python3.10 we can roll this out. Stacks on pydata#9417, merge that first * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with python3.10 we can roll this out.
Stacks on #9417, merge that first