-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cast numpy
scalars to arrays in as_compatible_data
#9403
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
17367f3
also call `np.asarray` on numpy scalars
keewis a673e61
check that numpy scalars are properly casted to arrays
keewis ff909b0
Merge branch 'main' into force-scalars-to-ndarray
keewis f61c6c2
Merge branch 'main' into force-scalars-to-ndarray
keewis 2b66e25
don't allow `numpy.ndarray` subclasses
keewis 01e83ad
Merge branch 'main' into force-scalars-to-ndarray
keewis 2fa2a2c
Merge branch 'main' into force-scalars-to-ndarray
keewis 42f7e8c
Merge branch 'main' into force-scalars-to-ndarray
keewis 9baaf50
Merge branch 'main' into force-scalars-to-ndarray
keewis f01ca2a
comment on the purpose of the explicit isinstance and `np.asarray`
keewis 9aed88d
Merge branch 'main' into force-scalars-to-ndarray
keewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worth adding a comment, noting that we want to cast numpy scalars to arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the latest commit does that, but please check if that's clear enough