-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy 2
compatibility in the pydap
backend
#9391
Conversation
I also noticed this xarray/ci/install-upstream-wheels.sh Lines 15 to 16 in a56a407
which also states a |
please remove that, as well. The reason that was done in an earlier PR is that this is setting up a upstream-dev test environment, which had |
doc/whats-new.rst
Outdated
- ``numpy>=2`` compatibility in the ``pydap`` backend (:pull:`9391`). | ||
By `Miguel Jimenez <https://github.com/Mikejmnez>`_ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this doesn't expose or fix any bugs I'd move this to "internal changes" and change it to something similar to "re-enable testing pydap
with numpy>=2
"
* re instate `pydap` to CI * include description on `what is new` * re-instate testing pydap * move whats new docs entry from `bug fixes` to `internal changes`
* main: (214 commits) Adds copy parameter to __array__ for numpy 2.0 (pydata#9393) `numpy 2` compatibility in the `pydap` backend (pydata#9391) pyarrow dependency added to doc environment (pydata#9394) Extend padding functionalities (pydata#9353) refactor GroupBy internals (pydata#9389) Combine `UnsignedIntegerCoder` and `CFMaskCoder` (pydata#9274) passing missing parameters to ZarrStore.open_store when opening a datatree (pydata#9377) Fix tests on big-endian systems (pydata#9380) Improve error message on `ds['x', 'y']` (pydata#9375) Improve error message for missing coordinate index (pydata#9370) Add flaky to TestNetCDF4ViaDaskData (pydata#9373) Make chunk manager an option in `set_options` (pydata#9362) Revise (pydata#9371) Remove duplicate word from docs (pydata#9367) Adding open_groups to BackendEntryPointEngine, NetCDF4BackendEntrypoint, and H5netcdfBackendEntrypoint (pydata#9243) Revise (pydata#9366) Fix rechunking to a frequency with empty bins. (pydata#9364) whats-new entry for dropping python 3.9 (pydata#9359) drop support for `python=3.9` (pydata#8937) Revise (pydata#9357) ...
* main: Adds copy parameter to __array__ for numpy 2.0 (pydata#9393) `numpy 2` compatibility in the `pydap` backend (pydata#9391) pyarrow dependency added to doc environment (pydata#9394) Extend padding functionalities (pydata#9353) refactor GroupBy internals (pydata#9389) Combine `UnsignedIntegerCoder` and `CFMaskCoder` (pydata#9274) passing missing parameters to ZarrStore.open_store when opening a datatree (pydata#9377) Fix tests on big-endian systems (pydata#9380) Improve error message on `ds['x', 'y']` (pydata#9375)
pydap=3.5
has a been released that is compatible with numpy 2 (among other features).including notable bug fixesinternal changes) are documented inwhats-new.rst
Don't know if I have the right permissions to push this PR, but at the very least this will bring up the attention that pydap is compatible with numpy>=2.0. Also, this has the potential to bring up additional issues to fix (even though tests on my local computer ran smoothly). Feel free to close/comment/etc etc.