Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2 compatibility in the pydap backend #9391

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

Mikejmnez
Copy link
Contributor

@Mikejmnez Mikejmnez commented Aug 21, 2024

pydap=3.5 has a been released that is compatible with numpy 2 (among other features).

  • This PR largely reverses pydata/xarray#9183.
  • User visible changes (including notable bug fixes internal changes) are documented in whats-new.rst

Don't know if I have the right permissions to push this PR, but at the very least this will bring up the attention that pydap is compatible with numpy>=2.0. Also, this has the potential to bring up additional issues to fix (even though tests on my local computer ran smoothly). Feel free to close/comment/etc etc.

@keewis keewis added run-upstream Run upstream CI CI Continuous Integration tools and removed run-upstream Run upstream CI labels Aug 21, 2024
@Mikejmnez
Copy link
Contributor Author

Mikejmnez commented Aug 21, 2024

I also noticed this

# temporarily remove backends
$conda remove -y pydap

which also states a temporary remove. I am not very familiar with the entire xarray test-suite so I am not sure what to make of the nighlty run (python 3.13?), and the reason to remove pydap from this test. I left it unchanged b/c it was not part of the PR I am reverting (see above), but can also remove the removal ha.

@keewis
Copy link
Collaborator

keewis commented Aug 21, 2024

please remove that, as well. The reason that was done in an earlier PR is that this is setting up a upstream-dev test environment, which had numpy>=2 much earlier than it was released. The environment is still python 3.12, though.

Comment on lines 53 to 54
- ``numpy>=2`` compatibility in the ``pydap`` backend (:pull:`9391`).
By `Miguel Jimenez <https://github.com/Mikejmnez>`_ .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this doesn't expose or fix any bugs I'd move this to "internal changes" and change it to something similar to "re-enable testing pydap with numpy>=2"

@keewis keewis added the run-upstream Run upstream CI label Aug 21, 2024
@max-sixty max-sixty added the plan to merge Final call for comments label Aug 21, 2024
@dcherian dcherian merged commit 93e410b into pydata:main Aug 22, 2024
30 of 34 checks passed
Copy link

welcome bot commented Aug 22, 2024

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

andrew-s28 pushed a commit to andrew-s28/xarray that referenced this pull request Aug 22, 2024
* re instate `pydap` to CI

* include description on `what is new`

* re-instate testing pydap

* move whats new docs entry from `bug fixes` to `internal changes`
dcherian added a commit to TomNicholas/xarray that referenced this pull request Aug 22, 2024
* main: (214 commits)
  Adds copy parameter to __array__ for numpy 2.0 (pydata#9393)
  `numpy 2` compatibility in the `pydap` backend (pydata#9391)
  pyarrow dependency added to doc environment (pydata#9394)
  Extend padding functionalities (pydata#9353)
  refactor GroupBy internals (pydata#9389)
  Combine `UnsignedIntegerCoder` and `CFMaskCoder` (pydata#9274)
  passing missing parameters to ZarrStore.open_store when opening a datatree (pydata#9377)
  Fix tests on big-endian systems (pydata#9380)
  Improve error message on `ds['x', 'y']` (pydata#9375)
  Improve error message for missing coordinate index (pydata#9370)
  Add flaky to TestNetCDF4ViaDaskData (pydata#9373)
  Make chunk manager an option in `set_options` (pydata#9362)
  Revise (pydata#9371)
  Remove duplicate word from docs (pydata#9367)
  Adding open_groups to BackendEntryPointEngine, NetCDF4BackendEntrypoint, and H5netcdfBackendEntrypoint (pydata#9243)
  Revise (pydata#9366)
  Fix rechunking to a frequency with empty bins. (pydata#9364)
  whats-new entry for dropping python 3.9 (pydata#9359)
  drop support for `python=3.9` (pydata#8937)
  Revise (pydata#9357)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 30, 2024
* main:
  Adds copy parameter to __array__ for numpy 2.0 (pydata#9393)
  `numpy 2` compatibility in the `pydap` backend (pydata#9391)
  pyarrow dependency added to doc environment (pydata#9394)
  Extend padding functionalities (pydata#9353)
  refactor GroupBy internals (pydata#9389)
  Combine `UnsignedIntegerCoder` and `CFMaskCoder` (pydata#9274)
  passing missing parameters to ZarrStore.open_store when opening a datatree (pydata#9377)
  Fix tests on big-endian systems (pydata#9380)
  Improve error message on `ds['x', 'y']` (pydata#9375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools plan to merge Final call for comments run-upstream Run upstream CI topic-backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants