Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding open_datatree backend-specific keyword arguments #9199

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Adding open_datatree backend-specific keyword arguments #9199

merged 6 commits into from
Jul 23, 2024

Conversation

aladinor
Copy link
Contributor

@aladinor aladinor commented Jul 1, 2024

doc/whats-new.rst Outdated Show resolved Hide resolved
@TomNicholas TomNicholas added topic-backends topic-DataTree Related to the implementation of a DataTree class labels Jul 1, 2024
@keewis
Copy link
Collaborator

keewis commented Jul 2, 2024

you might want to rebase / cherry-pick the two commits for this PR onto main, so there's only those two commits to check in this PR. If you don't have any idea how to do that, I can do it for you.

@aladinor aladinor closed this Jul 2, 2024
@aladinor aladinor reopened this Jul 2, 2024
@keewis
Copy link
Collaborator

keewis commented Jul 2, 2024

so unfortunately I can't push to your repository, because it is a fork of someone else's fork (and I'm not a maintainer on that fork). To fix that, you can either request someone from github to "reroute" your fork, or you can pull all your branches to local (I'm sure you did already), delete the repository and fork again. I'm not sure what would happen to this PR, though.

@keewis
Copy link
Collaborator

keewis commented Jul 2, 2024

if you want to fix up this PR (which is usually much quicker), you can also follow the steps yourself. Basically, what you do is:

git switch main
git pull
git switch open-dtree-kwargs
# rewind to main
git reset --hard HEAD~60
git merge main
# apply the two commits that were added in this PR
git cherry-pick 179b6960c6e2f49b38eda13a97d977a72bcb5990
git cherry-pick 563b5dbda4dabd253c38c9ca577015224447314f
git push --force

Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Do we need tests for this?

@JessicaS11
Copy link
Contributor

Do we need tests for this?

Funny you should ask - it turns out this functionality wasn't tested to begin with, so @eni-awowale and I are actually working on implementing some (started at SciPy sprints and not yet opened as a draft PR, but located here). Thanks to @santisoler for his help getting that effort started during Sprints!

@TomNicholas TomNicholas merged commit d0048ef into pydata:main Jul 23, 2024
28 checks passed
@TomNicholas
Copy link
Member

@JessicaS11 it would be great if you could push whatever you have as a PR (don't worry about perfecting it!) just so that those tests don't get lost in the ether

dcherian added a commit that referenced this pull request Jul 24, 2024
* main: (54 commits)
  Adding `open_datatree` backend-specific keyword arguments (#9199)
  [pre-commit.ci] pre-commit autoupdate (#9202)
  Restore ability to specify _FillValue as Python native integers (#9258)
  add backend intro and how-to diagram (#9175)
  Fix copybutton for multi line examples in double digit ipython cells (#9264)
  Update signature for _arrayfunction.__array__ (#9237)
  Add encode_cf_datetime benchmark (#9262)
  groupby, resample: Deprecate some positional args (#9236)
  Delete ``base`` and ``loffset`` parameters to resample (#9233)
  Update dropna docstring (#9257)
  Grouper, Resampler as public api (#8840)
  Fix mypy on main (#9252)
  fix fallback isdtype method (#9250)
  Enable pandas type checking (#9213)
  Per-variable specification of boolean parameters in open_dataset (#9218)
  test push
  Added a space to the documentation (#9247)
  Fix typing for test_plot.py (#9234)
  Allow mypy to run in vscode (#9239)
  Revert "Test main push"
  ...
dcherian added a commit to JoelJaeschke/xarray that referenced this pull request Jul 25, 2024
…monotonic-variable

* main: (995 commits)
  Adding `open_datatree` backend-specific keyword arguments (pydata#9199)
  [pre-commit.ci] pre-commit autoupdate (pydata#9202)
  Restore ability to specify _FillValue as Python native integers (pydata#9258)
  add backend intro and how-to diagram (pydata#9175)
  Fix copybutton for multi line examples in double digit ipython cells (pydata#9264)
  Update signature for _arrayfunction.__array__ (pydata#9237)
  Add encode_cf_datetime benchmark (pydata#9262)
  groupby, resample: Deprecate some positional args (pydata#9236)
  Delete ``base`` and ``loffset`` parameters to resample (pydata#9233)
  Update dropna docstring (pydata#9257)
  Grouper, Resampler as public api (pydata#8840)
  Fix mypy on main (pydata#9252)
  fix fallback isdtype method (pydata#9250)
  Enable pandas type checking (pydata#9213)
  Per-variable specification of boolean parameters in open_dataset (pydata#9218)
  test push
  Added a space to the documentation (pydata#9247)
  Fix typing for test_plot.py (pydata#9234)
  Allow mypy to run in vscode (pydata#9239)
  Revert "Test main push"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-backends topic-DataTree Related to the implementation of a DataTree class
Projects
Development

Successfully merging this pull request may close these issues.

5 participants