Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip the pandas datetime roundtrip test with pandas=3.0 #9104

Merged
merged 2 commits into from
Jun 12, 2024
+5 −0
Merged

skip the pandas datetime roundtrip test with pandas=3.0 #9104

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740db40
skip the roundtrip test with `pandas=3.0`
keewis Jun 12, 2024
2bca0fa
mention the relevant issue in the skip reason
keewis Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions properties/test_pandas_roundtrip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pytest

import xarray as xr
from xarray.tests import has_pandas_3

pytest.importorskip("hypothesis")
import hypothesis.extra.numpy as npst # isort:skip
Expand Down Expand Up @@ -110,6 +111,7 @@ def test_roundtrip_pandas_dataframe(df) -> None:
xr.testing.assert_identical(arr, roundtripped.to_xarray())


@pytest.mark.skipif(has_pandas_3, reason="fails to roundtrip on pandas 3")
keewis marked this conversation as resolved.
Show resolved Hide resolved
@given(df=dataframe_strategy)
def test_roundtrip_pandas_dataframe_datetime(df) -> None:
# Need to name the indexes, otherwise Xarray names them 'dim_0', 'dim_1'.
Expand Down
Loading