Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cdms2 #8441

Merged
merged 11 commits into from
Nov 14, 2023
Merged

remove cdms2 #8441

merged 11 commits into from
Nov 14, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Nov 10, 2023 •
edited
Loading

cdms2 is going to be abandoned at the end of this year, the recommended replacement is xcdat. We have deprecated our conversion functions in 2023.06.0 (release on June 23) which was less than 6 months ago, but given that cdms2 is already not installable on some architectures it makes sense to remove earlier.

This also appears to allow us to remove the special python=3.11 environment files.

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file Automation Github bots, testing workflows, release automation labels Nov 10, 2023
@keewis keewis added the run-upstream Run upstream CI label Nov 10, 2023
@keewis
Copy link
Collaborator Author

keewis commented Nov 10, 2023

there's some mentions of cdms2 / CDAT in the faq, so this will have to be updated before merging

@keewis keewis added the plan to merge Final call for comments label Nov 14, 2023
@keewis
Copy link
Collaborator Author

keewis commented Nov 14, 2023

@dcherian, there's some groupby failures that are not visible on main (or maybe they will appear soon?). Can you make sense of these?

@dcherian
Copy link
Contributor

Should be fixed after a numbagg release.

@dcherian
Copy link
Contributor

ugh there's stuff in test_units.py that won't be fixed. I'll take a look later. In the mean time we can merge this.

@dcherian dcherian merged commit 28053ba into pydata:main Nov 14, 2023
14 of 28 checks passed
@keewis keewis deleted the drop-cdms2 branch November 14, 2023 17:34
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
@dcherian
Merge branch 'main' into fix-zarr-append
8cdce90 
* main:
  [skip-ci] dev whats-new (pydata#8467)
  2023.11.0 Whats-new (pydata#8461)
  migrate the other CI to python 3.11 (pydata#8416)
  preserve vlen string dtypes, allow vlen string fill_values (pydata#7869)
  Pin mypy < 1.7 (pydata#8458)
  Fix typos found by codespell (pydata#8457)
  [skip-ci] Small updates to IO docs. (pydata#8452)
  Deprecate certain cftime frequency strings following pandas (pydata#8415)
  Added driver parameter for h5netcdf (pydata#8360)
  Raise exception in to_dataset if resulting variable is also the name of a coordinate (pydata#8433)
  Automatic region detection and transpose for `to_zarr()` (pydata#8434)
  remove `cdms2` (pydata#8441)
  Remove PseudoNetCDF (pydata#8446)
  Pin pint to >=0.22 (pydata#8445)
  Remove keep_attrs from resample signature (pydata#8444)
  Rename `to_array` to `to_dataarray` (pydata#8438)
  Add missing DataArray.dt.total_seconds() method (pydata#8435)
  Declare Dataset, DataArray, Variable, GroupBy unhashable (pydata#8392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
Automation Github bots, testing workflows, release automation CI Continuous Integration tools dependencies Pull requests that update a dependency file plan to merge Final call for comments run-upstream Run upstream CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instructions to create a development environment for M1/M2/osx-arm64
2 participants
@keewis @dcherian