Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move variable typed ops to NamedArray #8309

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Oct 14, 2023

This is highly WIP and probably everything is broken right now...
Just creating this now, so other people don't work on the same :)
Feel free to continue here with me.

@pydata/xarray

  1. what do we do with commonly used functions, is it ok to copy them?
  2. Moving the typed ops requires a lot of functions to be added to NamedArray, is there a consensus of what we want to move? Is it basically everything?
  3. Slowly the utils module is becomming a graveyard of stuff we dont want to put elsewhere, maybe we should at least move the typing stuff over to a types module.

@github-actions github-actions bot added the topic-NamedArray Lightweight version of Variable label Oct 14, 2023
@dcherian
Copy link
Contributor

what do we do with commonly used functions, is it ok to copy them?

I suggest moving them over and have Xarray depend on NamedArray, at least while we do the refactor.

Moving the typed ops requires a lot of functions to be added to NamedArray, is there a consensus of what we want to move? Is it basically everything?

Yes, I don't think there's much room to compromise on unary and binary ops.

maybe we should at least move the typing stuff over to a types module.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-NamedArray Lightweight version of Variable
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants