update pytest config and un-xfail some tests #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathause
commented
Sep 28, 2023
headtr1ck
reviewed
Sep 28, 2023
mathause
commented
Sep 28, 2023
mathause
commented
Sep 28, 2023
mathause
commented
Sep 28, 2023
|
Got the tests to pass. Thanks for the review @headtr1ck |
max-sixty
approved these changes
Sep 28, 2023
headtr1ck
approved these changes
Sep 28, 2023
headtr1ck
added
CI
dcherian
reviewed
Sep 28, 2023
| def test_vectorized_indexing_negative_step(self) -> None: | ||
| if not has_dask: | ||
| pytest.xfail( | ||
| reason="zarr without dask handles negative steps in slices incorrectly" |
There was a problem hiding this comment.
Is this still failing? I fixed an obscure bug here: #7586
There was a problem hiding this comment.
It's failing in the zarr SliceDimIndexer:
There was a problem hiding this comment.
Interesting. can you open an issue for this test please?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rstThis partly updates the pytest config as suggested in #8239 and un-xfails some tests (or xfails the tests more precisely).
See #8239 (comment) for why we cannot exactly follow the suggestions given in #8239