Add modules to check-untyped
#8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reviewing pydata#8241, I realize that we actually want `check-untyped-defs`, which is a bit less strict, but lets us add some more modules on. I did have to add a couple of ignores, think it's a reasonable tradeoff to add big modules like `computation` on. Errors with this enabled are actual type errors, not just `mypy` pedanticness, so would be good to get as much as possible into this list...
for more information, see https://pre-commit.ci
headtr1ck
reviewed
Sep 28, 2023
Co-authored-by: Michael Niklas <[email protected]>
for more information, see https://pre-commit.ci
max-sixty
commented
Sep 28, 2023
xarray/core/dataset.py
Outdated
| @@ -1478,7 +1478,7 @@ def __iter__(self) -> Iterator[Hashable]: | |||
| if TYPE_CHECKING: | |||
| # needed because __getattr__ is returning Any and otherwise | |||
| # this class counts as part of the SupportsArray Protocol | |||
| __array__ = None | |||
| __array__ = None # type: ignore[var-annotated,unused-ignore] | |||
There was a problem hiding this comment.
FYI I was getting this locally but not in CI — not sure why — but on balance seems reasonable to exclude. Possible a dependency issue; we can try removing some of these ignore[unused-ignore] in the future manually, given they definitionally elude our other checks...
|
@Illviljan is it OK if I merge? There may be small conflicts with #8241 — which seems unfair given you inspired these changes! Or merge #8241 and I'll resolve conflicts (unless you disagree, I'll merge later today, hope that's OK...) |
headtr1ck
approved these changes
Sep 28, 2023
Illviljan
approved these changes
Sep 28, 2023
|
Thanks @max-sixty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing #8241, I realize that we actually want
check-untyped-defs, which is a bit less strict, but lets us add some more modules on. I did have to add a couple of ignores, think it's a reasonable tradeoff to add big modules likecomputationon.Errors with this enabled are actual type errors, not just
mypypedanticness, so would be good to get as much as possible into this list...