-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setup.cfg
in favor of pyproject.toml
#8183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to do this since ages, haha! Thx :)
pyproject.toml
Outdated
@@ -6,7 +55,7 @@ requires = [ | |||
] | |||
|
|||
[tool.setuptools_scm] | |||
fallback_version = "999" | |||
fallback_version = "9999" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is leftover from your other PR :)
you can also remove |
@@ -52,7 +52,7 @@ | |||
except Exception: | |||
# Local copy or not installed with setuptools. | |||
# Disable minimum version checks on downstream libraries. | |||
__version__ = "999" | |||
__version__ = "9999" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI found another of these and added it to this PR
Yes, I'm not sure how long we need to wait for this. I'll merge this and we can remove |
I'd consider editable installs to be development-only, so I don't think we need to wait. If we did, we would have to wait until we can drop python 3.9, which according to SPEC0 would be pretty soon? If we do count |
Would this mean we can't develop on 3.9? |
as far as I remember, we had the rule to support the newest packaging tool version available at the release of the oldest supported python version.
once we drop support for a python version, developing on said version wouldn't make too much sense, anyways. I'm not saying that we should immediately drop that version once policy allows it (and I didn't check whether our policy aligns with the SPEC), but this would be one point in favor of doing so earlier |
Sorry — I had meant — would removing |
as long as you have a version of |
Super, thanks. Agree! |
My mistake from pydata#8183. I added `--strict-markers` so we can't make this sort of mistake again.
My mistake from #8183. I added `--strict-markers` so we can't make this sort of mistake again.
Nice - thanks! Can we also remove requirements.txt? I think https://github.com/pydata/xarray/network/dependencies also parses toml files. |
No longer needed, ref pydata#8183 (comment)
No longer needed, ref #8183 (comment)
My mistake from pydata#8183. I added `--strict-markers` so we can't make this sort of mistake again.
No longer needed, ref pydata#8183 (comment)
This is tested, but much of it was me tweaking from an LLM's attempt at the translation, so there may be small issues that aren't picked up in tests (but should be very easy to fix if these come up)