-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude dimensions used in faceting from squeeze #8174
Merged
headtr1ck
merged 8 commits into
pydata:main
from
krokosik:plot-facet-with-singleton-dim
Sep 17, 2023
Merged
Exclude dimensions used in faceting from squeeze #8174
headtr1ck
merged 8 commits into
pydata:main
from
krokosik:plot-facet-with-singleton-dim
Sep 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokosik
changed the title
Exclude dimensions used in faceting from squeeze
WIP: Exclude dimensions used in faceting from squeeze
Sep 11, 2023
krokosik
changed the title
WIP: Exclude dimensions used in faceting from squeeze
Exclude dimensions used in faceting from squeeze
Sep 11, 2023
headtr1ck
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
mathause
reviewed
Sep 12, 2023
mathause
reviewed
Sep 14, 2023
krokosik
force-pushed
the
plot-facet-with-singleton-dim
branch
from
September 14, 2023 15:56
683ccbe
to
2e59c8c
Compare
headtr1ck
approved these changes
Sep 14, 2023
dcherian
reviewed
Sep 16, 2023
max-sixty
pushed a commit
to max-sixty/xarray
that referenced
this pull request
Sep 17, 2023
* Exclude dimensions used in faceting from squeeze * Add unit test for facetting singleton dim * Add bug fix to changelog * Move test to proper class * Update doc/whats-new.rst * Apply suggestions from code review * Update doc/whats-new.rst --------- Co-authored-by: Mathias Hauser <[email protected]> Co-authored-by: Deepak Cherian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
Implements @headtr1ck solution from the issue.