Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dimensions used in faceting from squeeze #8174

Merged
merged 8 commits into from
Sep 17, 2023

Conversation

krokosik
Copy link
Contributor

Implements @headtr1ck solution from the issue.

@krokosik krokosik changed the title Exclude dimensions used in faceting from squeeze WIP: Exclude dimensions used in faceting from squeeze Sep 11, 2023
@krokosik krokosik changed the title WIP: Exclude dimensions used in faceting from squeeze Exclude dimensions used in faceting from squeeze Sep 11, 2023
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@headtr1ck headtr1ck added the plan to merge Final call for comments label Sep 12, 2023
doc/whats-new.rst Outdated Show resolved Hide resolved
doc/whats-new.rst Outdated Show resolved Hide resolved
@krokosik krokosik force-pushed the plot-facet-with-singleton-dim branch from 683ccbe to 2e59c8c Compare September 14, 2023 15:56
doc/whats-new.rst Outdated Show resolved Hide resolved
doc/whats-new.rst Outdated Show resolved Hide resolved
@headtr1ck headtr1ck merged commit c439432 into pydata:main Sep 17, 2023
24 checks passed
@welcome
Copy link

welcome bot commented Sep 17, 2023

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

max-sixty pushed a commit to max-sixty/xarray that referenced this pull request Sep 17, 2023
* Exclude dimensions used in faceting from squeeze

* Add unit test for facetting singleton dim

* Add bug fix to changelog

* Move test to proper class

* Update doc/whats-new.rst

* Apply suggestions from code review

* Update doc/whats-new.rst

---------

Co-authored-by: Mathias Hauser <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotting facet grid with singleton dimension should create a facet grid with size 1
4 participants