Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure the contributing guide #7681

Merged
merged 15 commits into from
Apr 13, 2023

Conversation

harshitha1201
Copy link
Contributor

Have added the communication channels. (#4361)

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution @harshitha1201 ! That part of the contributor's guide definitely wasn't up-to-date, so thank you for noticing that.

I've made a few suggestions just to improve the flow of the text or slightly emphasise certain things.

doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
@harshitha1201
Copy link
Contributor Author

Removed text having the broken link, which closes #6687

Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition.
Couple of minor remarks.

doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
@0xSaksham
Copy link

Hey is this issue complete? If not I can work on it.

@harshitha1201
Copy link
Contributor Author

Hey is this issue complete? If not I can work on it.

I'm working on it.

@harshitha1201
Copy link
Contributor Author

Untitled Document 5.pdf
@TomNicholas I'm getting this error.
I have done a full clean build, the errors are decreased. But there are still some errors.

@TomNicholas
Copy link
Member

@harshitha1201 if it passes the CI, it should be fine. The error you are getting looks like something to do with importing rasterio, which is an optional backend anyway.

@harshitha1201
Copy link
Contributor Author

@harshitha1201 if it passes the CI, it should be fine. The error you are getting looks like something to do with importing rasterio, which is an optional backend anyway.

okay! thank you

@harshitha1201
Copy link
Contributor Author

@keewis I have done some changes, please review.

@harshitha1201
Copy link
Contributor Author

@headtr1ck I have done some additions and some deletions too to the contributing guide. Please let me know if any changes are needed.

Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

doc/contributing.rst Outdated Show resolved Hide resolved
doc/contributing.rst Outdated Show resolved Hide resolved
@harshitha1201
Copy link
Contributor Author

@TomNicholas please review

@dcherian dcherian requested a review from TomNicholas April 6, 2023 03:58
@headtr1ck headtr1ck added the plan to merge Final call for comments label Apr 6, 2023
@dcherian
Copy link
Contributor

Thanks @harshitha1201 !

@dcherian dcherian merged commit 61eb2d4 into pydata:main Apr 13, 2023
@harshitha1201
Copy link
Contributor Author

Thanks @harshitha1201 !

Thank you!!

dcherian added a commit to dcherian/xarray that referenced this pull request Apr 18, 2023
* main: (34 commits)
  Update whats-new.rst
  Fix binning by unsorted array (pydata#7762)
  Bump codecov/codecov-action from 3.1.1 to 3.1.2 (pydata#7760)
  Fix typing errors using mypy 1.2 (pydata#7752)
  [skip-ci] dev whats-new
  Add whats-new for v2023.04.0 (pydata#7757)
  remove the `black` hook (pydata#7756)
  reword the what's new entry for the `pandas` 2.0 dtype changes (pydata#7755)
  restructure the contributing guide (pydata#7681)
  Continue to use nanosecond-precision Timestamps in precision-sensitive areas (pydata#7731)
  minor doc updates to clarify extensions using accessors (pydata#7751)
  align: Avoid reindexing when join="exact" (pydata#7736)
  `pandas=2.0` support (pydata#7724)
  Clarify vectorized indexing documentation (pydata#7747)
  Avoid recasting a CFTimeIndex (pydata#7735)
  fix typo (pydata#7746)
  [pre-commit.ci] pre-commit autoupdate (pydata#7745)
  Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pydata#7743)
  preserve boolean dtype in encoding (pydata#7720)
  [skip-ci] Add alignment benchmarks (pydata#7738)
  ...
@harshitha1201 harshitha1201 deleted the restructure-contributing-guide branch August 9, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants