Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new compression arguments. #7551

Merged
merged 37 commits into from
Dec 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f8a0014
Support for the new compression arguments.
garciampred Feb 17, 2023
42c5a97
Merge branch 'main' into fix_compression_options
dcherian Mar 16, 2023
7abf103
significant_digit and other missing keys added
markelg Mar 22, 2023
fa408c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 22, 2023
1b9f6db
Merge branch 'main' into fix_compression_options
markelg Apr 24, 2023
8c0c584
Merge branch 'pydata:main' into fix_compression_options
markelg Jun 20, 2023
e489a32
test for the new compression argument
markelg Jun 21, 2023
fff18a8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 21, 2023
a89f816
move the new test to TestNetCDF4Data
markelg Jun 21, 2023
2feafc5
fixed conflict
markelg Jun 21, 2023
371d2d7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 21, 2023
e74ec56
Merge branch 'main' into fix_compression_options
rabernat Sep 28, 2023
34718f4
Merge branch 'pydata:main' into fix_compression_options
markelg Oct 30, 2023
f77d126
simplify this line (code review)
markelg Oct 30, 2023
2df3387
Added entry to whats-new
markelg Oct 30, 2023
011b939
Merge branch 'main' into fix_compression_options
markelg Nov 14, 2023
d39173c
Merge branch 'main' into fix_compression_options
dcherian Nov 15, 2023
da5dee8
Merge branch 'pydata:main' into fix_compression_options
markelg Dec 11, 2023
ee57f4a
Merge branch 'main' into fix_compression_options
kmuehlbauer Dec 18, 2023
c2ce8d5
bump netcdf4 to 1.6.2 in min-all-deps.yml
kmuehlbauer Dec 18, 2023
e5d0609
parametrize compression in test
kmuehlbauer Dec 18, 2023
d77e3fd
Revert "bump netcdf4 to 1.6.2 in min-all-deps.yml"
kmuehlbauer Dec 18, 2023
fbffef2
check netCDF4 version and skip test if netcdf4 version <1.6.2
kmuehlbauer Dec 18, 2023
5b271fa
fix typing
kmuehlbauer Dec 18, 2023
a2a41ab
Larger chunks to avoid random blosc errors
markelg Dec 18, 2023
b98c926
use decorator to skip old netCDF4 versions
markelg Dec 18, 2023
74b74d7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 18, 2023
5d69807
Merge branch 'main' into fix_compression_options
kmuehlbauer Dec 19, 2023
a4e4d8c
remove stale version-property
kmuehlbauer Dec 19, 2023
4ae2bca
fix whats-new.rst
kmuehlbauer Dec 19, 2023
f8f37f4
fix requires-decorator
kmuehlbauer Dec 19, 2023
b7e56fe
fix for asserts of other tests that use test data
markelg Dec 19, 2023
138a439
Apply suggestions from code review
kmuehlbauer Dec 20, 2023
9e25e6e
Update xarray/tests/__init__.py
kmuehlbauer Dec 20, 2023
4e59c9a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 20, 2023
674d35f
Merge branch 'main' into fix_compression_options
kmuehlbauer Dec 20, 2023
bc74cd8
Update xarray/tests/test_backends.py
kmuehlbauer Dec 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify this line (code review)
  • Loading branch information
markelg authored Oct 30, 2023
commit f77d1269f89da109e0844f84017b48de5953f1d1
3 changes: 1 addition & 2 deletions xarray/backends/netCDF4_.py
Original file line number Diff line number Diff line change
@@ -528,8 +528,7 @@ def prepare_variable(
fill_value=fill_value,
)
default_args.update(encoding)
markelg marked this conversation as resolved.
Show resolved Hide resolved
if "_FillValue" in default_args:
default_args.pop("_FillValue")
default_args.pop("_FillValue", None)
nc4_var = self.ds.createVariable(**default_args)

nc4_var.setncatts(attrs)
Loading