Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the docs environment #7442

Merged
merged 14 commits into from
Mar 3, 2023
Merged

update the docs environment #7442

merged 14 commits into from
Mar 3, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jan 16, 2023

Most notably:

Edit: it seems this is blocked by sphinx-book-theme pinning sphinx to >=3,<5. They already changed the pin, we're just waiting on a release

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Jan 16, 2023
@dcherian
Copy link
Contributor

dcherian commented Feb 14, 2023

We still have an error but sphinx is up to 5.3.0

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/7442/lib/python3.10/site-packages/sphinx/cmd/build.py", line 281, in build_main
    app.build(args.force_all, args.filenames)

...

  File "/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/7442/lib/python3.10/site-packages/sphinx/builders/__init__.py", line 568, in write
    self._write_parallel(sorted(docnames),
  File "/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/7442/lib/python3.10/site-packages/sphinx/builders/__init__.py", line 615, in _write_parallel
    tasks.add_task(write_process, arg, on_chunk_done)
  File "/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/7442/lib/python3.10/site-packages/sphinx/util/parallel.py", line 100, in add_task
    self._join_one()
  File "/home/docs/checkouts/readthedocs.org/user_builds/xray/conda/7442/lib/python3.10/site-packages/sphinx/util/parallel.py", line 126, in _join_one
    raise SphinxParallelError(*result)
sphinx.errors.SphinxParallelError: AttributeError: can't set attribute '_table_row_index'

Sphinx parallel build error:
AttributeError: can't set attribute '_table_row_index'

@keewis
Copy link
Collaborator Author

keewis commented Feb 14, 2023

I think we should pin sphinx-book-theme to some appropriate version, right now we have 0.0.41, which is about two years old (and is probably the last version that does not contain the upper bound on sphinx)

@keewis
Copy link
Collaborator Author

keewis commented Feb 14, 2023

as expected that environment is not solvable because sphinx-book-theme didn't have a release since the bump of the sphinx version

@keewis keewis marked this pull request as draft February 14, 2023 17:19
@Illviljan
Copy link
Contributor

Seems we're experiencing this issue now:
pydata/pydata-sphinx-theme#1220

@keewis keewis marked this pull request as ready for review March 2, 2023 22:04
@keewis
Copy link
Collaborator Author

keewis commented Mar 3, 2023

with the release of sphinx-book-theme=1.0.0 yesterday we can finally move this forward.

In the process I fixed a few other docs issues so I'll merge this now to avoid having the docs CI fail on main.

@keewis keewis enabled auto-merge (squash) March 3, 2023 10:04
@keewis keewis merged commit 43ba095 into pydata:main Mar 3, 2023
@keewis keewis deleted the docs-environment branch March 3, 2023 10:17
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 9, 2023
* main:
  Preserve `base` and `loffset` arguments in `resample` (pydata#7444)
  ignore the `pkg_resources` deprecation warning (pydata#7594)
  Update contains_cftime_datetimes to avoid loading entire variable array (pydata#7494)
  Support first, last with dask arrays (pydata#7562)
  update the docs environment (pydata#7442)
  Add xCDAT to list of Xarray related projects (pydata#7579)
  [pre-commit.ci] pre-commit autoupdate (pydata#7565)
  fix nczarr when libnetcdf>4.8.1 (pydata#7575)
  use numpys SupportsDtype (pydata#7521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants