Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require to explicitly defining optional dimensions such as hue and markersize #7277

Merged
merged 29 commits into from
Feb 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2425bdc
Prioritize mpl kwargs when hue/size isn't defined.
Illviljan Nov 10, 2022
09fedc6
Update dataarray_plot.py
Illviljan Nov 10, 2022
277ec39
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Nov 11, 2022
a2740e0
rename vars for clarity
Illviljan Nov 12, 2022
4bce4a9
Handle int coords
Illviljan Nov 13, 2022
b885289
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2022
192fd47
Update dataarray_plot.py
Illviljan Nov 13, 2022
42b7232
Merge branch 'dont_guess_for_some_kwargs' of https://github.com/Illvi…
Illviljan Nov 13, 2022
b534f9a
Move funcs to utils and use in facetgrid, fix int coords in facetgrid
Illviljan Nov 13, 2022
f6d8a67
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2022
a53c17f
Update dataarray_plot.py
Illviljan Nov 13, 2022
1bd971f
Merge branch 'dont_guess_for_some_kwargs' of https://github.com/Illvi…
Illviljan Nov 13, 2022
2ee9e47
Update utils.py
Illviljan Nov 13, 2022
cf7a016
Update utils.py
Illviljan Nov 13, 2022
c4a0c48
Update facetgrid.py
Illviljan Nov 13, 2022
f4a26da
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Nov 20, 2022
65e2367
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Nov 22, 2022
a5e6842
typing fixes
Illviljan Nov 23, 2022
58944eb
Only guess x-axis.
Illviljan Nov 23, 2022
04694f9
fix tests
Illviljan Nov 23, 2022
fa49f55
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Dec 18, 2022
151b9cf
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Jan 20, 2023
681ec75
rename function to a better name.
Illviljan Jan 26, 2023
1b3ba5e
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Jan 26, 2023
db0f64e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 26, 2023
0c140b2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 26, 2023
d72827a
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Feb 9, 2023
762950d
Merge branch 'main' into dont_guess_for_some_kwargs
Illviljan Feb 9, 2023
bcdd818
Update whats-new.rst
Illviljan Feb 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
pre-commit-ci[bot] committed Nov 13, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b885289222818a4b34f503497d6be5da8474f61e
5 changes: 4 additions & 1 deletion xarray/plot/dataarray_plot.py
Original file line number Diff line number Diff line change
@@ -253,7 +253,10 @@ def _infer_line_data2(
--------
>>> # Make sure int coords are plotted:
>>> a = xr.DataArray(
... data=[1, 2], coords={1: ("x", [0, 1], {"units": "s"})}, dims=("x",), name="a"
... data=[1, 2],
... coords={1: ("x", [0, 1], {"units": "s"})},
... dims=("x",),
... name="a",
... )
>>> plts = xr.plot.dataarray_plot._infer_line_data2(
... a,