Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary build dependencies, use build defaults, strict twine check #6979

Merged
merged 1 commit into from
Sep 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pypi-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install setuptools setuptools-scm wheel twine check-manifest
python -m pip install build twine
andersy005 marked this conversation as resolved.
Show resolved Hide resolved

- name: Build tarball and wheels
run: |
git clean -xdf
git restore -SW .
python -m build --sdist --wheel .
python -m build

- name: Check built artifacts
run: |
python -m twine check dist/*
python -m twine check --strict dist/*
andersy005 marked this conversation as resolved.
Show resolved Hide resolved
pwd
if [ -f dist/xarray-0.0.0.tar.gz ]; then
echo "❌ INVALID VERSION NUMBER"
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/testpypi-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install build setuptools setuptools-scm wheel twine check-manifest
python -m pip install build twine
python -m pip install tomli tomli_w
andersy005 marked this conversation as resolved.
Show resolved Hide resolved

- name: Disable local versions
Expand All @@ -35,12 +35,11 @@ jobs:
- name: Build tarball and wheels
run: |
git clean -xdf
python -m build --sdist --wheel .
python -m build

- name: Check built artifacts
run: |
python -m twine check dist/*
pwd
python -m twine check --strict dist/*
andersy005 marked this conversation as resolved.
Show resolved Hide resolved
if [ -f dist/xarray-0.0.0.tar.gz ]; then
echo "❌ INVALID VERSION NUMBER"
exit 1
Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
[build-system]
requires = [
"setuptools>=42",
"wheel",
"setuptools_scm[toml]>=3.4",
"setuptools_scm_git_archive",
"setuptools-scm[toml]>=3.4",
"setuptools-scm-git-archive",
]
build-backend = "setuptools.build_meta"

Expand Down