-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve typing of DataArray and Dataset reductions #6746
Conversation
Noble effort, but I think we will have to wait until python/mypy#12846 is solved, otherwise users will get false positives... |
Agreed, I just reached the same conclusion. |
Since python/mypy#12846 seems to have been fixed, we could give this another go. Edit: Actually, now that the |
72ea77f
to
379bf9d
Compare
defb134
to
2deffe9
Compare
Rebasing my branch required solving quite some merge conflicts, which was to be expected as this PR had run more than 400 commits behind. I adapted the PR to now use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this old PR.
Couple minor remarks.
Also, feel free to add an entry to what's new!
Thanks for this PR! |
Thank you for taking care of the last few steps yourself and merging this PR! I just came back from vacation and just realized it would have been nicer if I had mentioned that I was going to be unresponsive for several weeks. |
This PR makes the typing of reduction methods (
count
,all
,any
,max
,min
,mean
,prod
,sum
,std
,var
,median
) forDataset
andDataArray
consistent with the typing of most other methods ofDataset
andDataArray
after the great recent improvements by @headtr1ck in e.g. #6661.